-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Coil 3 in coil-integration and add more Kotlin targets #428
Draft
jan-tennert
wants to merge
15
commits into
development
Choose a base branch
from
coil3
base: development
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-tennert
changed the title
Add support for Coil 3 in coil-integration and add more supported Kotlin targets
Add support for Coil 3 in coil-integration and add more Kotlin targets
Jan 15, 2024
2 tasks
jan-tennert
added
the
blocked by dependency
This feature cannot be implemented as one ore more dependencies need an update.
label
Feb 28, 2024
# Conflicts: # gradle/libs.versions.toml # plugins/CoilIntegration/src/commonMain/kotlin/io/github/jan/supabase/coil/SupabaseStorageFetcher.kt
# Conflicts: # gradle.properties # gradle/libs.versions.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked by dependency
This feature cannot be implemented as one ore more dependencies need an update.
enhancement
New feature or request
freezer
On hold
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature (closes #425)
What is the current behavior?
Coil 2 is used (which only supports Android)
What is the new behavior?
Migration to Coil 3 and support for JVM, iOS and JS targets. Wasm support will come once #311 is merged and coil supports it.
Additional context
I'll merge it as soon Coil 3 is in a more stable state
May need to update the README once Coil 3 is out (because some links do not makes sense yet)