Fixed mixup in the config reading that caused keyboard to reset, also…

… use reference instead of pointer in JoystickConfig
SuperTux · Aug 20, 2014 · 77d7720 · 77d7720
1 parent eaa1442
commit 77d7720
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/control/joystick_config.cpp b/src/control/joystick_config.cpp
@@ -155,12 +155,12 @@ JoystickConfig::bind_joybutton(JoyId joy_id, int button, Controller::Control con
 }
 
 void
-JoystickConfig::read(const lisp::Lisp* joystick_lisp)
+JoystickConfig::read(const lisp::Lisp& joystick_lisp)
 {
-  joystick_lisp->get("dead-zone", dead_zone);
-  joystick_lisp->get("jump-with-up", jump_with_up_joy);
+  joystick_lisp.get("dead-zone", dead_zone);
+  joystick_lisp.get("jump-with-up", jump_with_up_joy);
 
-  lisp::ListIterator iter(joystick_lisp);
+  lisp::ListIterator iter(&joystick_lisp);
   while(iter.next())
   {
     if (iter.item() == "map")

diff --git a/src/control/joystick_config.hpp b/src/control/joystick_config.hpp
@@ -55,7 +55,7 @@ class JoystickConfig
   void bind_joyaxis(JoyId joy_id, int axis, Controller::Control c);
   void bind_joyhat(JoyId joy_id, int dir, Controller::Control c);
 
-  void read(const lisp::Lisp* joystick_lisp);
+  void read(const lisp::Lisp& joystick_lisp);
   void write(Writer& writer);
 
 private:

diff --git a/src/supertux/gameconfig.cpp b/src/supertux/gameconfig.cpp
@@ -108,13 +108,13 @@ Config::load()
     const lisp::Lisp* keymap_lisp = config_control_lisp->get_lisp("keymap");
     if (keymap_lisp)
     {
-      keyboard_config.read(*config_control_lisp);
+      keyboard_config.read(*keymap_lisp);
     }
 
     const lisp::Lisp* joystick_lisp = config_control_lisp->get_lisp("joystick");
     if (joystick_lisp)
     {
-      joystick_config.read(joystick_lisp);
+      joystick_config.read(*joystick_lisp);
     }
   }