Fix for coverity #29394

SuperTux · Feb 15, 2015 · db14b80 · db14b80
1 parent 114f3c0
commit db14b80
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/object/infoblock.cpp b/src/object/infoblock.cpp
@@ -103,11 +103,16 @@ Player*
 InfoBlock::get_nearest_player()
 {
   // FIXME: does not really return nearest player
+  //  for (std::vector<Player*>::iterator playerIter = players.begin(); playerIter != players.end(); ++playerIter) {
+  //    Player* player = *playerIter;
+  //    return player;
+  //  }
 
   std::vector<Player*> players = Sector::current()->get_players();
-  for (std::vector<Player*>::iterator playerIter = players.begin(); playerIter != players.end(); ++playerIter) {
-    Player* player = *playerIter;
-    return player;
+  if(players.size() > 0)
+  {
+    // Return first player
+    return players[0];
   }
 
   return 0;