Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKPhotoBrowser(originImage:photos:animatedFromView:) replacement #363

Open
jdanthinne opened this issue Apr 3, 2019 · 11 comments
Open

SKPhotoBrowser(originImage:photos:animatedFromView:) replacement #363

jdanthinne opened this issue Apr 3, 2019 · 11 comments

Comments

@jdanthinne
Copy link
Contributor

SKPhotoBrowser(originImage:photos:animatedFromView:) being marked as deprecated, what is the best alternative?
@aslanmehmetsalih
Copy link

i think SKPhotoBrowser(photos: photos, initialPageIndex: initialPageIndex) is best alternative.

@jdanthinne
Copy link
Contributor Author

Yes, but what if I want to keep the zoom animation from the original tapped view?

@zenghaojim33
Copy link

zenghaojim33 commented Jun 18, 2019 •
edited

+1

1 similar comment
@derekcoder
Copy link

+1

@ajself
Copy link

ajself commented Aug 19, 2019

The README does not reflect that this convenience initializer is marked as deprecated either, nor is there any documentation as to why.

@HappyIosDeveloper
Copy link

+1

1 similar comment
@alfredcc
Copy link

+1

@buithuyen
Copy link

+1.
I was wondering about it too.

@RainManGO
Copy link

+1

1 similar comment
@joseph-517
Copy link

+1

@LittleLittleKang
Copy link

I think we should use "SKPhotoBrowserDelegate", as shown in the sample code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests