Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rename I18n.normalize_translation_keys to normalize_keys and finally …
…make it public.
- Loading branch information
Sven Fuchs
committed
Jan 21, 2010
1 parent
8f02aa2
commit 20b05fe
Showing
6 changed files
with
22 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20b05fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might have added a deprecation warning for this one, because it breaks other gems like formtastic.
20b05fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, Iain. I should probably re-release.
20b05fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it wasn't formtastic btw: It was Rails 2.3! Calling t(".foo") in views, when the translation wasn't present. An edgecase, maybe, but there nonetheless.
http://github.com/rails/rails/blob/2-3-stable/actionpack/lib/action_view/helpers/translation_helper.rb#L18
20b05fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, this broke Rails build as well. We should not change APIs in tiny releases!
Sven, could you please re-release with a deprecation warning? :D
20b05fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josevalim it's not really API change, since the normalize_translation_keys was private ;)
20b05fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iain hahaha! That's true! :D
20b05fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the prompt feedback, guys!
I've re-added the method and delegated to normalize_keys. Pushed to rubygems, too. http://rubygems.org/gems/i18n/versions/0.3.5