Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Won't work with Rails 6.1 #75

Open
Fodoj opened this issue Nov 28, 2020 · 5 comments
Open

Won't work with Rails 6.1 #75

Fodoj opened this issue Nov 28, 2020 · 5 comments

Comments

@Fodoj
Copy link

Fodoj commented Nov 28, 2020

I gave it a try on Rails 6.1 RC and figured that due to this change: rails/rails@437ab20, routing-filter gem won't work anymore. Sadly I don't have capacity to submit a PR, but at least this files need to be updated to support new object types (though most likely then it will break suppor for Rails <6.1):

  • lib/routing_filter/filter.rb
  • lib/routing_filter/adapters/rails.r
@hasghari
Copy link
Contributor

hasghari commented Dec 24, 2020 •
edited

@svenfuchs I have a working solution for Rails 6.1 but before I create a PR for it, I wanted to see whether you're ok with making the following changes:

  1. Release a new version (0.6.4) with the gemspec updated to restrict the rails version to '>= 4.2', '< 6.1'
  2. Cut a new branch for Rails 6.1 with updated gemspec >= 6.1 and release a new version (1.0.0) to reflect backwards incompatibility.

Update: PR #76 supports Rails 6.1 and maintains backwards compatibility.

@geoffharcourt
Copy link

#76 has been merged, I think we just need a new gem release!

@adsteel
Copy link

adsteel commented Apr 5, 2021

Thanks so much for #76! Looking forward to the new release.

@techvineet
Copy link

When will the new version with #76 release?

@kennyadsl
Copy link

Hey, thanks for merging #76! Anything I can do to help releasing a new version?

kennyadsl added a commit to solidusio-contrib/solidus_globalize that referenced this issue Jun 24, 2021
@kennyadsl
Fix bundle issues in test/development
045d12c 
Remove loading a fork when testing against newer
versions of Solidus/Rails.

Now that svenfuchs/routing-filter#76
has been release that's not needed anymore.

We still have to rely on the GitHub version of the gem when
used with Rails 6.1 because the compatibility fix has been
merged but not yet released. see
svenfuchs/routing-filter#75.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Fodoj @kennyadsl @geoffharcourt @techvineet @hasghari @adsteel