Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test pipeline for PRs #55

Open
diocas opened this issue Jul 16, 2020 · 0 comments
Open

Test pipeline for PRs #55

diocas opened this issue Jul 16, 2020 · 0 comments
Assignees
@omazapa
Labels
priority:medium type:enhancement Improvement to an existing functionality

Comments

@diocas
Copy link
Contributor

diocas commented Jul 16, 2020 •
edited

When a PR is opened, we should run a pipeline that compiles and tests the code to validate that everything works.
Since we have a monorepo, we first need to see which extensions need to be built/tested. So we should check which paths changed (https://github.com/marketplace/actions/get-changed-files) and then cd and build/test each of the extensions referenced in the PR.
We should also call a linter to check that everything is properly formatted.
@diocas diocas added type:enhancement Improvement to an existing functionality priority:medium labels Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omazapa omazapa

Labels
priority:medium type:enhancement Improvement to an existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@omazapa @diocas