Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Find solution for TaxonomyBundle #161

Open
dantleech opened this issue May 1, 2013 · 25 comments
Open

Find solution for TaxonomyBundle #161

dantleech opened this issue May 1, 2013 · 25 comments

Comments

@dantleech
Copy link
Member

The CMF certainly needs a Taxonomy feature. The question is how we go about it.

I think we should use the vespolina/VespolinaTaxonomy library, and potentially the vespolina\VespolinaTaxonomyBundle.

I am guessing that in any case we will need at least an integration bundle in the CMF - SymfonyCmfTaxonomyBundle.

\cc @inspiran - what do you think? In your opinion should we use the TaxonomyBundle or would that bundle be coupled with Vespolina? And if so, it would be a shame not to share things like form types and other SF2 stuff.

@inspiran
Copy link

inspiran commented May 2, 2013

the taxonomy library is supposed to be framework agnostic. Hence the taxonomy bundle is required to integrate it with symfony2. No other vespolina ecommerce component should be required at all.

The implementation of a PHPCR Gateway would be needed (and is planned) to make the integration with CMF complete. Forms, potential widgets (eg. tag completion) could be shared amongst both projects.

@dantleech
Copy link
Member Author

ok, so I guess we can take it as given that we can collaborate on the Taxonomy library (I will be happy to do a PR for PHPCR-ODM integration). But where the Bundle is concerned, its not clear to me if we can share the same instance.

I notice already in the VespolinaTaxonomyBundle a shopping cart reference in Configuration.php - although the method doesn't exist and the Configuration class is not used :)

So, I guess the questions are:

  • Is the VespolinaTaxonomyBundle going to be application agnostic?
  • and then will we need to create SymfonyCmfTaxonomyBundle?

@dantleech
Copy link
Member Author

I guess an example of CMF stuff might be having SonataAdmin integration and CMF Blocks included.

@dbu
Copy link
Member

dbu commented May 6, 2013

probably just using the vespolina taxonomy component will be easier and make more sense. if the bundle has cool non DI stuff that we want to use, we should help them push it up into the component.

unless the vespolina bundle is really meant totally independent and they want us to help ensure it really is independent.

@lsmith77
Copy link
Member

@dbu
Copy link
Member

dbu commented Sep 9, 2013

see also Sylius/Sylius#316

@dbu
Copy link
Member

dbu commented Oct 8, 2013

so aparently sonata just created a ClassificationBundle http://sonata-project.org/blog/2013/10/7/newsbundle-classificationbundle
this sounds like another approach to the same issues. i would have hoped we could agree on one common thing, would have been best for interoperability and to focus the efforts... whatever, i guess we should consider this bundle as well.

@rvanlaak
Copy link

rvanlaak commented Oct 8, 2013

The SonataClassificationBundle does not seem to have a stable version yet. They are still working on the documentation. In other words, this is not planned for cmf v1 right?

Main difference between VespolinaTaxonomy, SonataClassificationBundle and SyliusTaxonomiesBundle seems:

  • SonataClassificationBundle also has tags and categories, aside of taxonomies
  • VespolinaTaxonomy uses MongoDB, no ORM layer (yet)
  • SonataClassificationBundle uses the SonataAdmin approach, SyliusTaxonomiesBundle has FormTypes

Making use of FormTypes has my preference. I am planning on integrating symfony-cmf, and a taxonomybundle for my application. That is why probably I will implement the bundle that is the result from the discussion in this issue.

@dbu
Copy link
Member

dbu commented Oct 8, 2013

hi, no for 1.0 we won't have any of this, as we will tag like tomorrow.
but its great if you want to work on this topic. i still have in my todo
list to create a PR for SyliusTaxonomyBundle to map their tags with
phpcr-odm. it seemed quite doable and the bundle does not depend on too
many other things.

@dantleech
Copy link
Member Author

I have put some time in to designing and brainstorming a ("CMF") TaxonomyBundle. I had been reluctant to move on this as there are already a few candidate projects. I decided to go ahead and persue a new one just because I wanted to and the candidate projects didn't correspond with my vision. Will see how it turns out and if it will be a suitable candidate for a CMF bundle.

@rvanlaak
Copy link

rvanlaak commented Oct 8, 2013

@dantleech does your concept bundle has tags, categories and taxonomies? That directly would make it superiour to the SonataClassificationBundle, since it probably does not have the sonata dependencies.

I would use it, if it is possible to implement it for my current Sf2.3 application.

@dantleech
Copy link
Member Author

The concept has Taxonomies and Taxons. Basically you can attach taxons to anything and taxons belong to taxonomies. Taxonomies can either dynamic or fixed, flat or hierachical, and sourced by taxonomy drivers - you would be able to load taxonomies from a database source or directly from configuration.

A category is just a many-to-one relationship with a Taxon.
Tags are many-to-many relationship with Taxons.

I'm just playing with ideas at the moment, any prototype version would probably have some CMF deps, if it works out really well I will make the reusable stuff into a component.

@dbu
Copy link
Member

dbu commented Oct 10, 2013

stumbled over yet another one: https://github.com/Kunstmaan/KunstmaanTaggingBundle (kunstmaan seems to be a clone (feature wise) of sonata: having an admin, pages, blocks (pageparts), seo, media and so on...)

@rvanlaak
Copy link

rvanlaak commented Nov 4, 2013

Any update on the bundle that will be used in symfony-cmf?

@dantleech
Copy link
Member Author

Not yet. @dbu wants to work on integrating the Sylius TaxonomyBundle but I think he is having difficulty finding time, as mentioned before I am interested in (attempting) to create a new bundle, but also am lacking in time.

@rvanlaak
Copy link

The KunstmaanTaggingBundle has dependencies on, for example, their own AdminList bundle. Another option I've found is:

https://github.com/FabienPennequin/FPNTagBundle
https://github.com/FabienPennequin/DoctrineExtensions-Taggable

@dbu
Copy link
Member

dbu commented Nov 25, 2013

okay, there is my PR on sylius to add phpcr-odm mappings: Sylius/Sylius#647

they have subtree splits for their TaxonomyBundle and the ResourceBundle which seems to be the sylius equivalent of our CoreBundle.

i would be very glad if somebody could try this stuff out and report if it works as expected.

@xjailbreaker
Copy link

hi, let me bump the issue...
so, what's the more appropriate and the best way/bundle to add taxonomy to the Symfony-CMF?

@dantleech
Copy link
Member Author

@xjailbreaker the most productive thing would probably be trying out the branch above - Sylius/Sylius#647 - or you could use an ORM taxonomy and find a way to bridge ORM and PHPCR-ODM.

@xjailbreaker
Copy link

Sylius taxonomy isn't usable as a standalone bundle (this one has a lot of hardcoded deps, etc). Requiring this extension will download all the sylius and so on...
Just try to add Sylius/Taxononies into a clean Symfony2 installation and y'll found all the Sylius bundles in yr vendor folder, so, i don't think that Sylius/Taxonomy is the best choice at all

@dantleech
Copy link
Member Author

I just started a bundle specific to PHPCR ODM: https://github.com/dantleech/PhpcrTaxonomyBundle

Basically the focus is just on having something that will work now and which isn't worried about supporting all the storage engines.

Its nearly "finished" I just need to get PHPCR-ODM to behave.

@dbu
Copy link
Member

dbu commented Jan 4, 2014

@xjailbreaker strange that you got all of sylius installed, when reading https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/TaxonomiesBundle/composer.json#L26 it depends on sylius/resource-bundle only, which in turn does not require any other sylius bundles https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/ResourceBundle/composer.json#L22

are you sure you only required sylius/taxonomies-bundle and not sylius/sylius? or is the doc mentioning an outdated version maybe that depends on too many things? composer now says that the current master branch is 1.0-dev so maybe you should use 1.0.*@dev instead of 0.2?

@binhle410
Copy link

May I get the status on this issue ? How are things going ?

@dbu
Copy link
Member

dbu commented Sep 19, 2016

as far as i know, nobody is working on this at the moment. @dantleech would you happen to know anything more?

@dantleech
Copy link
Member Author

Nothing new. You can checkout the Sylius TaxonomyBundle which offers, I
think, basic tree taxonomies, or my old PHPCR taxonomy bundle:

https://github.com/dantleech/PhpcrTaxonomyBundle

Which offers "tag" taxonomies for PHPCR, but although its being used on
my personal website I doubt there will be any further development there.

On Mon, Sep 19, 2016 at 02:00:37AM -0700, David Buchmann wrote:

as far as i know, nobody is working on this at the moment. [1]@dantleech
would you happen to know anything more?


You are receiving this because you were mentioned.
Reply to this email directly, [2]view it on GitHub, or [3]mute the thread.

Reverse link: [4]unknown

References

Visible links

  1. https://github.com/dantleech
  2. Find solution for TaxonomyBundle #161 (comment)
  3. https://github.com/notifications/unsubscribe-auth/AAgZcc6zf4Fx-9U2fwIjDVwLthP7BhXpks5qrk81gaJpZM4An3OW
  4. Find solution for TaxonomyBundle #161 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants