Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #19786 Update profiler's layout to use flexbox (javiereguiluz)
This PR was squashed before being merged into the 2.8 branch (closes #19786). Discussion ---------- Update profiler's layout to use flexbox | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - ### Problem The layout of the profiler uses some old CSS tricks to make the sidebar look like a same-height sidebar (`margin-bottom: -99999px;` and `padding-bottom: 99999px;`, a large `min-height` in the content, etc.) This works most of the time ... but there are some edge cases where the sidebar looks ugly (it doesn't have the same height as the main content). ### Solution This proposal updates the profiler layout to use CSS flexbox. * It looks and behaves exactly like before ... but it also fixes all the edge cases. * flexbox has ~90% of global browser support --> so it should be 100% of Symfony developers --- ~~Sadly **there is one issue that I cannot solve**:~~ ~~* The "Performance" panel doesn't work on Chrome and Firefox (but it works on Safari!!)~~ ~~* The problem is that the `getContainerWidth()` function in `time.html.twig` template doesn't return the right value and the generated canvas has a wrong width.~~ ~~Any clues?~~ It's fixed now! Commits ------- d986ac0 Update profiler's layout to use flexbox
- Loading branch information