Skip to content

Commit

Permalink
bug #29992 [DependencyInjection] fix DOM element namespace URL access…
Browse files Browse the repository at this point in the history
… (xabbuh)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[DependencyInjection] fix DOM element namespace URL access

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

429bddf fix DOM element namespace URL access
  • Loading branch information
nicolas-grekas committed Jan 26, 2019
2 parents d0effcd + 429bddf commit 1aa652e
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -672,7 +672,7 @@ private function validateAlias(\DOMElement $alias, $file)
}

foreach ($alias->childNodes as $child) {
if (!$child instanceof \DOMElement && self::NS !== $child->namespaceURI) {
if (!$child instanceof \DOMElement || self::NS !== $child->namespaceURI) {
continue;
}
if (!\in_array($child->localName, ['deprecated'], true)) {
Expand Down

0 comments on commit 1aa652e

Please sign in to comment.