[Console] ensure exit code between 0-254

255 is reserved by PHP and should not be used also put this code inside the codeCoverageIgnore block because it cannot be tested with phpunit
symfony · Jun 9, 2013 · 6b9180a · 6b9180a
1 parent 445b2e3
commit 6b9180a
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/Symfony/Component/Console/Application.php b/src/Symfony/Component/Console/Application.php
@@ -126,11 +126,9 @@ public function run(InputInterface $input = null, OutputInterface $output = null
         }
 
         if ($this->autoExit) {
-            if ($statusCode > 255) {
-                $statusCode = 255;
-            }
+            // ensure exit code is between 0-254 (255 is reserved by PHP and should not be used)
             // @codeCoverageIgnoreStart
-            exit($statusCode);
+            exit(max(0, min(254, $statusCode)));
             // @codeCoverageIgnoreEnd
         }