[Validator] The Type constraint now accepts the "Boolean" type instead of "boolean".

Hugo Hamon · Hugo Hamon · commit 73312ab5e932 · 2011-10-11T12:27:45.000+02:00
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
diff --git a/src/Symfony/Component/Validator/Constraints/TypeValidator.php b/src/Symfony/Component/Validator/Constraints/TypeValidator.php
@@ -35,7 +35,8 @@ public function isValid($value, Constraint $constraint)
             return true;
         }
 
-        $type = $constraint->type == 'boolean' ? 'bool' : $constraint->type;
+        $type = strtolower($constraint->type);
+        $type = $type == 'boolean' ? 'bool' : $constraint->type;
         $function = 'is_'.$type;
 
         if (function_exists($function) && call_user_func($function, $value)) {
diff --git a/tests/Symfony/Tests/Component/Validator/Constraints/AssertTypeValidatorTest.php b/tests/Symfony/Tests/Component/Validator/Constraints/AssertTypeValidatorTest.php
@@ -62,6 +62,8 @@ public function getValidValues()
         $file = $this->createFile();
 
         return array(
+            array(true, 'Boolean'),
+            array(false, 'Boolean'),
             array(true, 'boolean'),
             array(false, 'boolean'),
             array(true, 'bool'),

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,8 @@ public function isValid($value, Constraint $constraint)`
`35`	`35`	`return true;`
`36`	`36`	`}`
`37`	`37`
`38`		`- $type = $constraint->type == 'boolean' ? 'bool' : $constraint->type;`
	`38`	`+ $type = strtolower($constraint->type);`
	`39`	`+ $type = $type == 'boolean' ? 'bool' : $constraint->type;`
`39`	`40`	`$function = 'is_'.$type;`
`40`	`41`
`41`	`42`	`if (function_exists($function) && call_user_func($function, $value)) {`