[Process] added a Process:isSucessful() method

symfony · Sep 16, 2010 · 7734f44 · 7734f44
1 parent 61f1866
commit 7734f44
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/Symfony/Component/BrowserKit/Client.php b/src/Symfony/Component/BrowserKit/Client.php
@@ -235,7 +235,7 @@ protected function doRequestInProcess($request)
         $process = new PhpProcess($this->getScript($request));
         $process->run();
 
-        if ($process->getExitCode() > 0) {
+        if (!$process->isSuccessful()) {
             throw new \RuntimeException($process->getErrorOutput());
         }
 

diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -194,6 +194,16 @@ public function getExitCode()
         return $this->exitcode;
     }
 
+    /**
+     * Checks if the process ended successfully.
+     *
+     * @return Boolean true if the process ended successfully, false otherwise
+     */
+    public function isSuccessful()
+    {
+        return 0 == $this->exitcode;
+    }
+
     /**
      * Returns true if the child process has been terminated by an uncaught signal.
      *