feature #54661 [TypeInfo] Handle custom collection objects properly (…

…mtarld)

This PR was merged into the 7.1 branch.

Discussion
----------

[TypeInfo] Handle custom collection objects properly

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Issues        |
| License       | MIT

Understand custom collection objects.

Commits
-------

b2a7627 [TypeInfo] Handle collection types properly

src/Symfony/Component/TypeInfo/Tests/Fixtures/DummyCollection.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Symfony\Component\TypeInfo\Tests\Fixtures;
+
+final class DummyCollection implements \IteratorAggregate
+{
+    public function getIterator(): \Traversable
+    {
+        return [];
+    }
+}

src/Symfony/Component/TypeInfo/Tests/TypeResolver/StringTypeResolverTest.php

@@ -16,6 +16,7 @@
 use Symfony\Component\TypeInfo\Exception\UnsupportedException;
 use Symfony\Component\TypeInfo\Tests\Fixtures\AbstractDummy;
 use Symfony\Component\TypeInfo\Tests\Fixtures\Dummy;
+use Symfony\Component\TypeInfo\Tests\Fixtures\DummyCollection;
 use Symfony\Component\TypeInfo\Tests\Fixtures\DummyWithTemplates;
 use Symfony\Component\TypeInfo\Type;
 use Symfony\Component\TypeInfo\TypeContext\TypeContext;
@@ -167,6 +168,7 @@ public function resolveDataProvider(): iterable
         yield [Type::collection(Type::object(\IteratorAggregate::class)), \IteratorAggregate::class];
         yield [Type::collection(Type::object(\IteratorAggregate::class), Type::string()), \IteratorAggregate::class.'<string>'];
         yield [Type::collection(Type::object(\IteratorAggregate::class), Type::bool(), Type::string()), \IteratorAggregate::class.'<string, bool>'];
+        yield [Type::collection(Type::object(DummyCollection::class), Type::bool(), Type::string()), DummyCollection::class.'<string, bool>'];
     }
 
     public function testCannotResolveNonStringType()

src/Symfony/Component/TypeInfo/TypeResolver/StringTypeResolver.php

@@ -53,8 +53,6 @@
  */
 final class StringTypeResolver implements TypeResolverInterface
 {
-    private const COLLECTION_CLASS_NAMES = [\Traversable::class, \Iterator::class, \IteratorAggregate::class, \ArrayAccess::class, \Generator::class];
-
     /**
      * @var array<string, bool>
      */
@@ -166,7 +164,7 @@ private function getTypeFromNode(TypeNode $node, ?TypeContext $typeContext): Typ
                 default => $this->resolveCustomIdentifier($node->name, $typeContext),
             };
 
-            if ($type instanceof ObjectType && \in_array($type->getClassName(), self::COLLECTION_CLASS_NAMES, true)) {
+            if ($type instanceof ObjectType && (is_a($type->getClassName(), \Traversable::class, true) || is_a($type->getClassName(), \ArrayAccess::class, true))) {
                 return Type::collection($type);
             }
 
@@ -203,7 +201,7 @@ private function getTypeFromNode(TypeNode $node, ?TypeContext $typeContext): Typ
                 }
             }
 
-            if ($type instanceof ObjectType && \in_array($type->getClassName(), self::COLLECTION_CLASS_NAMES, true)) {
+            if ($type instanceof ObjectType && (is_a($type->getClassName(), \Traversable::class, true) || is_a($type->getClassName(), \ArrayAccess::class, true))) {
                 return match (\count($variableTypes)) {
                     1 => Type::collection($type, $variableTypes[0]),
                     2 => Type::collection($type, $variableTypes[1], $variableTypes[0]),