minor #31679 [Validator] Remove DateTime support in date/time validat…

…ors (ro0NL)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Validator] Remove DateTime support in date/time validators

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

See #25015

Commits
-------

37c1cbb [Validator] Remove DateTime support in date/time validators

src/Symfony/Component/Validator/Constraints/DateTimeValidator.php

@@ -34,12 +34,6 @@ public function validate($value, Constraint $constraint)
             return;
         }
 
-        if ($value instanceof \DateTimeInterface) {
-            @trigger_error(sprintf('Validating a \\DateTimeInterface with "%s" is deprecated since version 4.2. Use "%s" instead or remove the constraint if the underlying model is already type hinted to \\DateTimeInterface.', DateTime::class, Type::class), E_USER_DEPRECATED);
-
-            return;
-        }
-
         if (!is_scalar($value) && !(\is_object($value) && method_exists($value, '__toString'))) {
             throw new UnexpectedValueException($value, 'string');
         }

src/Symfony/Component/Validator/Constraints/DateValidator.php

@@ -52,12 +52,6 @@ public function validate($value, Constraint $constraint)
             return;
         }
 
-        if ($value instanceof \DateTimeInterface) {
-            @trigger_error(sprintf('Validating a \\DateTimeInterface with "%s" is deprecated since version 4.2. Use "%s" instead or remove the constraint if the underlying model is already type hinted to \\DateTimeInterface.', Date::class, Type::class), E_USER_DEPRECATED);
-
-            return;
-        }
-
         if (!is_scalar($value) && !(\is_object($value) && method_exists($value, '__toString'))) {
             throw new UnexpectedValueException($value, 'string');
         }

src/Symfony/Component/Validator/Constraints/TimeValidator.php

@@ -52,12 +52,6 @@ public function validate($value, Constraint $constraint)
             return;
         }
 
-        if ($value instanceof \DateTimeInterface) {
-            @trigger_error(sprintf('Validating a \\DateTimeInterface with "%s" is deprecated since version 4.2. Use "%s" instead or remove the constraint if the underlying model is already type hinted to \\DateTimeInterface.', Time::class, Type::class), E_USER_DEPRECATED);
-
-            return;
-        }
-
         if (!is_scalar($value) && !(\is_object($value) && method_exists($value, '__toString'))) {
             throw new UnexpectedValueException($value, 'string');
         }

src/Symfony/Component/Validator/Tests/Constraints/DateTimeValidatorTest.php

@@ -36,28 +36,6 @@ public function testEmptyStringIsValid()
         $this->assertNoViolation();
     }
 
-    /**
-     * @group legacy
-     * @expectedDeprecation Validating a \DateTimeInterface with "Symfony\Component\Validator\Constraints\DateTime" is deprecated since version 4.2. Use "Symfony\Component\Validator\Constraints\Type" instead or remove the constraint if the underlying model is already type hinted to \DateTimeInterface.
-     */
-    public function testDateTimeClassIsValid()
-    {
-        $this->validator->validate(new \DateTime(), new DateTime());
-
-        $this->assertNoViolation();
-    }
-
-    /**
-     * @group legacy
-     * @expectedDeprecation Validating a \DateTimeInterface with "Symfony\Component\Validator\Constraints\DateTime" is deprecated since version 4.2. Use "Symfony\Component\Validator\Constraints\Type" instead or remove the constraint if the underlying model is already type hinted to \DateTimeInterface.
-     */
-    public function testDateTimeImmutableClassIsValid()
-    {
-        $this->validator->validate(new \DateTimeImmutable(), new DateTime());
-
-        $this->assertNoViolation();
-    }
-
     /**
      * @expectedException \Symfony\Component\Validator\Exception\UnexpectedValueException
      */

src/Symfony/Component/Validator/Tests/Constraints/DateValidatorTest.php

@@ -36,28 +36,6 @@ public function testEmptyStringIsValid()
         $this->assertNoViolation();
     }
 
-    /**
-     * @group legacy
-     * @expectedDeprecation Validating a \DateTimeInterface with "Symfony\Component\Validator\Constraints\Date" is deprecated since version 4.2. Use "Symfony\Component\Validator\Constraints\Type" instead or remove the constraint if the underlying model is already type hinted to \DateTimeInterface.
-     */
-    public function testDateTimeClassIsValid()
-    {
-        $this->validator->validate(new \DateTime(), new Date());
-
-        $this->assertNoViolation();
-    }
-
-    /**
-     * @group legacy
-     * @expectedDeprecation Validating a \DateTimeInterface with "Symfony\Component\Validator\Constraints\Date" is deprecated since version 4.2. Use "Symfony\Component\Validator\Constraints\Type" instead or remove the constraint if the underlying model is already type hinted to \DateTimeInterface.
-     */
-    public function testDateTimeImmutableClassIsValid()
-    {
-        $this->validator->validate(new \DateTimeImmutable(), new Date());
-
-        $this->assertNoViolation();
-    }
-
     /**
      * @expectedException \Symfony\Component\Validator\Exception\UnexpectedValueException
      */

src/Symfony/Component/Validator/Tests/Constraints/TimeValidatorTest.php

@@ -36,17 +36,6 @@ public function testEmptyStringIsValid()
         $this->assertNoViolation();
     }
 
-    /**
-     * @group legacy
-     * @expectedDeprecation Validating a \DateTimeInterface with "Symfony\Component\Validator\Constraints\Time" is deprecated since version 4.2. Use "Symfony\Component\Validator\Constraints\Type" instead or remove the constraint if the underlying model is already type hinted to \DateTimeInterface.
-     */
-    public function testDateTimeClassIsValid()
-    {
-        $this->validator->validate(new \DateTime(), new Time());
-
-        $this->assertNoViolation();
-    }
-
     /**
      * @expectedException \Symfony\Component\Validator\Exception\UnexpectedValueException
      */
@@ -103,15 +92,4 @@ public function getInvalidTimes()
             ['00:00:60', Time::INVALID_TIME_ERROR],
         ];
     }
-
-    /**
-     * @group legacy
-     * @expectedDeprecation Validating a \DateTimeInterface with "Symfony\Component\Validator\Constraints\Time" is deprecated since version 4.2. Use "Symfony\Component\Validator\Constraints\Type" instead or remove the constraint if the underlying model is already type hinted to \DateTimeInterface.
-     */
-    public function testDateTimeImmutableIsValid()
-    {
-        $this->validator->validate(new \DateTimeImmutable(), new Time());
-
-        $this->assertNoViolation();
-    }
 }