Optimize EntityType by only loading choices for values in the same wa…

…y that EntityLoader customization does (if you provide a query_builder).
symfony · Feb 21, 2015 · a108445 · a108445 · coudenysj · Mar 23, 2015
1 parent 7b9bc80
commit a108445
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/Symfony/Bridge/Doctrine/Form/ChoiceList/EntityChoiceList.php b/src/Symfony/Bridge/Doctrine/Form/ChoiceList/EntityChoiceList.php
@@ -218,8 +218,10 @@ public function getChoicesForValues(array $values)
         if (!$this->loaded) {
             // Optimize performance in case we have an entity loader and
             // a single-field identifier
-            if ($this->idAsValue && $this->entityLoader) {
-                $unorderedEntities = $this->entityLoader->getEntitiesByIds($this->idField, $values);
+            if ($this->idAsValue) {
+                $unorderedEntities = $this->entityLoader
+                    ? $this->entityLoader->getEntitiesByIds($this->idField, $values)
+                    : $this->em->getRepository($this->class)->findBy(array($this->idField => $values));
                 $entitiesByValue = array();
                 $entities = array();