Skip to content

Commit c200b42

Browse files
committed
Merge remote branch 'kriswallsmith/http/forwarded-secure'
* kriswallsmith/http/forwarded-secure: [HttpFoundation] added support for X-Forwarded-Port request header
2 parents e150ffd + ae46150 commit c200b42

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

src/Symfony/Component/HttpFoundation/Request.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ public function getScheme()
413413

414414
public function getPort()
415415
{
416-
return $this->server->get('SERVER_PORT');
416+
return $this->headers->get('X-Forwarded-Port') ?: $this->server->get('SERVER_PORT');
417417
}
418418

419419
/**

tests/Symfony/Tests/Component/HttpFoundation/RequestTest.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -711,4 +711,14 @@ public function testGetRequestFormat()
711711
$this->assertEquals(null, $request->setRequestFormat('foo'));
712712
$this->assertEquals('foo', $request->getRequestFormat(null));
713713
}
714+
715+
public function testForwardedSecure()
716+
{
717+
$request = new Request();
718+
$request->headers->set('X-Forwarded-Proto', 'https');
719+
$request->headers->set('X-Forwarded-Port', 443);
720+
721+
$this->assertTrue($request->isSecure());
722+
$this->assertEquals(443, $request->getPort());
723+
}
714724
}

0 commit comments

Comments
 (0)