Skip to content

Commit

Permalink
minor #33162 [FrameworkBundle] Add parameter types from Routing (derr…
Browse files Browse the repository at this point in the history
…abus)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[FrameworkBundle] Add parameter types from Routing

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32179
| License       | MIT
| Doc PR        | N/A

This PR makes FrameworkBundle incompatible with Routing 4.4. Let's merge whenever we feel ready to do the bump.

Commits
-------

b5ba1d4 [FrameworkBundle] Add parameter types from Routing.
  • Loading branch information
nicolas-grekas committed Aug 16, 2019
2 parents e8f4dfc + b5ba1d4 commit d68b255
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Expand Up @@ -24,7 +24,7 @@ class RedirectableCompiledUrlMatcher extends CompiledUrlMatcher implements Redir
/**
* {@inheritdoc}
*/
public function redirect($path, $route, $scheme = null)
public function redirect(string $path, string $route, string $scheme = null)
{
return [
'_controller' => 'Symfony\\Bundle\\FrameworkBundle\\Controller\\RedirectController::urlRedirectAction',
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/FrameworkBundle/composer.json
Expand Up @@ -27,7 +27,7 @@
"symfony/polyfill-mbstring": "~1.0",
"symfony/filesystem": "^4.4|^5.0",
"symfony/finder": "^4.4|^5.0",
"symfony/routing": "^4.4|^5.0"
"symfony/routing": "^5.0"
},
"require-dev": {
"doctrine/cache": "~1.0",
Expand Down

0 comments on commit d68b255

Please sign in to comment.