[2.3] SCA for Components - reference mismatches

Author: kalessil

src/Symfony/Component/HttpFoundation/Session/Attribute/NamespacedAttributeBag.php

@@ -43,6 +43,7 @@ public function __construct($storageKey = '_sf2_attributes', $namespaceCharacter
      */
     public function has($name)
     {
+        // reference mismatch: if fixed, re-introduced in array_key_exists; keep as it is
         $attributes = $this->resolveAttributePath($name);
         $name = $this->resolveKey($name);
 
@@ -58,6 +59,7 @@ public function has($name)
      */
     public function get($name, $default = null)
     {
+        // reference mismatch: if fixed, re-introduced in array_key_exists; keep as it is
         $attributes = $this->resolveAttributePath($name);
         $name = $this->resolveKey($name);
 

src/Symfony/Component/PropertyAccess/PropertyAccessor.php

@@ -304,8 +304,10 @@ private function writeProperty(&$object, $property, $singular, $value)
                 // see https://github.com/symfony/symfony/issues/4670
                 $itemsToAdd = is_object($value) ? iterator_to_array($value) : $value;
                 $itemToRemove = array();
-                $propertyValue = $this->readProperty($object, $property);
+                $propertyValue = &$this->readProperty($object, $property);
                 $previousValue = $propertyValue[self::VALUE];
+                // remove reference to avoid modifications
+                unset($propertyValue);
 
                 if (is_array($previousValue) || $previousValue instanceof \Traversable) {
                     foreach ($previousValue as $previousItem) {