How to load a config with FrameworkConfig $framework from a bundle

[jfsenechal]

Hello

How can I load from my bundle extension a config file who use Frameworkconfig

return static function (FrameworkConfig $framework) {
    $messenger = $framework->messenger();
    $messenger
        ->transport('async', [
            'dsn' => '%env(MESSENGER_TRANSPORT_DSN)%',
            'options' => [
                'auto_setup' => true,
                'use_notify' => true,//PostgreSQL’s
                'check_delayed_interval' => 60000,
            ],
            'retry_strategy' => [
                'max_retries' => 3,
                'multiplier' => 2,
            ],
        ]);
    $messenger->routing('Symfony\Component\Mailer\Messenger\SendEmailMessage')->senders(['async']);
};

From my extension

class AcMarcheMercrediExtension extends Extension implements PrependExtensionInterface
{
    public function load(array $configs, ContainerBuilder $containerBuilder): void
    {
        $phpFileLoader = new PhpFileLoader($containerBuilder, new FileLocator(__DIR__.'/../../config'));
        $phpFileLoader->load('services.php');
        $phpFileLoader->load('packages/messenger.php'); //doesn't work     
    }

I have this error :

Could not resolve argument "Symfony\Config\FrameworkConfig $framework" for "/var/www/appli/src/AcMarche/Mercredi/src/DependencyInjection/../../config/packages/messenger.php".

[ro0NL]

what's the previous exception?

symfony/src/Symfony/Component/DependencyInjection/Loader/PhpFileLoader.php

Lines 138 to 140 in e34cd7d

	} catch (InvalidArgumentException | \LogicException $e) {
	throw new \InvalidArgumentException(sprintf('Could not resolve argument "%s" for "%s".', $type.' $'.$parameter->getName(), $path), 0, $e);
	}

[jfsenechal]

LogicException
You cannot use the ConfigBuilders without providing a class implementing ConfigBuilderGeneratorInterface.

You can see my bundle here https://github.com/acmarche/mercredi/blob/master/src/DependencyInjection/AcMarcheMercrediExtension.php

[ro0NL]

using the DelegatingLoader as linked above

[jfsenechal]

Like that ?

       
        $resolver = new LoaderResolver([
            $phpFileLoader,
            new ClosureLoader($containerBuilder),
        ]);

        $delegatingLoader = new DelegatingLoader($resolver);
        $delegatingLoader->load('packages/messenger.php');

I have the same error Could not resolve argument "Symfony\Config\FrameworkConfig $framework" for "/var/www/mercredi5/src/AcMarche/Mercredi/src/DependencyInjection/../../config/packages/messenger.php".

[ro0NL]

the kernel uses its own loader, as linked above:

symfony/src/Symfony/Component/HttpKernel/Kernel.php

Lines 757 to 772 in 76a414c

	protected function getContainerLoader(ContainerInterface $container)
	{
	$env = $this->getEnvironment();
	$locator = new FileLocator($this);
	$resolver = new LoaderResolver([
	new XmlFileLoader($container, $locator, $env),
	new YamlFileLoader($container, $locator, $env),
	new IniFileLoader($container, $locator, $env),
	new PhpFileLoader($container, $locator, $env, class_exists(ConfigBuilderGenerator::class) ? new ConfigBuilderGenerator($this->getBuildDir()) : null),
	new GlobFileLoader($container, $locator, $env),
	new DirectoryLoader($container, $locator, $env),
	new ClosureLoader($container, $env),
	]);
	return new DelegatingLoader($resolver);
	}

here we see php maps to new PhpFileLoader($container, $locator, $env, class_exists(ConfigBuilderGenerator::class) ? new ConfigBuilderGenerator($this->getBuildDir()) : null), where a ConfigBuilderGenerator is passed, which solves the error.

In your case another loader is created by you: $phpFileLoader = new PhpFileLoader($containerBuilder, new FileLocator(__DIR__.'/../../config')); where no ConfigBuilderGenerator is passed, which causes the error.

[jfsenechal]

Yes it works :-)

Thank you :-)

public function load(array $configs, ContainerBuilder $containerBuilder): void
    {
        $this->loader->load('services.php');
        $this->loader->load('packages/messenger.php');
}

protected function initPhpFilerLoader(ContainerBuilder $containerBuilder): PhpFileLoader
    {
        return new PhpFileLoader(
            $containerBuilder,
            new FileLocator(__DIR__.'/../../config/'),
            null,
            class_exists(ConfigBuilderGenerator::class) ? new ConfigBuilderGenerator(
                $containerBuilder->getParameter('kernel.cache_dir')
            ) : null
        );
    }

[ro0NL]

nice. I'd fill in the environment parameter as well (getParameter(kernel.environment). IIUC it enables compatibility with certain features like https://symfony.com/blog/new-in-symfony-5-3-configure-multiple-environments-in-a-single-file

cc @Nyholm WDYT about improving this?