Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic metrics for LogThreadedSourceDriver like eps, msg_size_max, msg_size_avg #4786

Open
kovgeri01 opened this issue Jan 11, 2024 · 0 comments

Comments

@kovgeri01
Copy link
Contributor

Description of the problem

Currently the LogThreadedSourceDriver does not have a generic list of metrics that the child implementation could use like how LogWriter, LogReader, LogThreadedDestDriver have one. This causes some boiler plate on the actual implementation side to do when someone want to be consistent with the other implementation.

Proposed solution

Add the similiar solution as it currently in LogThreadedDestDriver so that the child impementations will only have to use the corresponding functions to increment the generic metrics instead of them handling the registering and unregistering themselves

Additional context

I am proposing to do this as it can decrease such boilerplate like what happened in case of PR#4423
Also I would like to see it in a different PR as this might be quite huge impacting every children of LogThreadedSourceDriver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant