Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cov says function *signatures* are not covered while the *body* is fully covered? #327

Open
fzyzcjy opened this issue Dec 22, 2023 · 2 comments
Labels
needs-mcve Call for participation: This issue needs a Minimal Complete and Verifiable Example

Comments

@fzyzcjy
Copy link

fzyzcjy commented Dec 22, 2023

Hi thanks for the project! However, I am quite confused about what it gives. Consider the two following examples, it says, function signatures are not covered while the body is fully covered. I cannot understand how this can happen :/

Example 1:
https://app.codecov.io/gh/fzyzcjy/flutter_rust_bridge/blob/master/frb_codegen%2Fsrc%2Flibrary%2Futils%2Fdart_repository%2Fdart_repo.rs

image

Example 2:
https://app.codecov.io/gh/fzyzcjy/flutter_rust_bridge/blob/master/frb_codegen%2Fsrc%2Flibrary%2Fcodegen%2Fgenerator%2Fwire%2Frust%2Fspec_generator%2Fcodec%2Fdco%2Fencoder%2Fty%2Fdelegate.rs

image

@taiki-e
Copy link
Owner

taiki-e commented Dec 23, 2023

Hmm. This is very odd. Do other report formats (such as --codecov, --html) have the same problem?

@taiki-e taiki-e added the needs-mcve Call for participation: This issue needs a Minimal Complete and Verifiable Example label Dec 23, 2023
@fzyzcjy
Copy link
Author

fzyzcjy commented Dec 23, 2023

Thank you for the reply.

I later find more weird problems. For example, sometimes a comment line itself is red (while we know comments are not executable code at all...).

I changed to codecov reporter and do not use lcov currently (because I need to hack the output to remove these manually).

@taiki-e taiki-e added S-needs-repro Status: This issue has no reproduction and needs a reproduction to make progress. needs-mcve Call for participation: This issue needs a Minimal Complete and Verifiable Example and removed needs-mcve Call for participation: This issue needs a Minimal Complete and Verifiable Example S-needs-repro Status: This issue has no reproduction and needs a reproduction to make progress. labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-mcve Call for participation: This issue needs a Minimal Complete and Verifiable Example
Projects
None yet
Development

No branches or pull requests

2 participants