Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when reference-style links are used more than once #226

Open
carlsmedstad opened this issue Dec 16, 2022 · 0 comments
Open

Crash when reference-style links are used more than once #226

carlsmedstad opened this issue Dec 16, 2022 · 0 comments

Comments

@carlsmedstad
Copy link
Contributor

carlsmedstad commented Dec 16, 2022

Hey 馃憢

We get a crash when using reference-style links and referring to a link more than once, for example like this:

Lorem ipsum [my link][].

Lorem ipsum [my link][].

[my link]: www.someurl.com

This is the stack trace:

/usr/local/lib/node_modules/markdown-link-check/node_modules/async/dist/async.js:324
            if (fn === null) throw new Error("Callback was already called.");
                             ^

Error: Callback was already called.
    at /usr/local/lib/node_modules/markdown-link-check/node_modules/async/dist/async.js:324:36
    at /usr/local/lib/node_modules/markdown-link-check/node_modules/async/dist/async.js:248:17
    at /usr/local/lib/node_modules/markdown-link-check/index.js:129:13
    at /usr/local/lib/node_modules/markdown-link-check/node_modules/link-check/lib/proto/http.js:117:21
    at done (/usr/local/lib/node_modules/markdown-link-check/node_modules/needle/lib/needle.js:463:14)
    at ClientRequest.<anonymous> (/usr/local/lib/node_modules/markdown-link-check/node_modules/needle/lib/needle.js:547:16)
    at Object.onceWrapper (node:events:628:26)
    at ClientRequest.emit (node:events:513:28)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:688:27)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17)

I'm only able to reproduce this with version 3.10.3 on Alpine (3.17 specifically), the same version does not produce a crash on Arch. Downgrading to version 3.10.2 seems to mitigate the issue.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant