Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use psetv2 instead of psetv0 #154

Open
altafan opened this issue Aug 5, 2022 · 2 comments
Open

Use psetv2 instead of psetv0 #154

altafan opened this issue Aug 5, 2022 · 2 comments

Comments

@altafan
Copy link
Contributor

altafan commented Aug 5, 2022

Once #125 is closed, we must update ldk version and use the new psetv2 format by default.

@altafan
Copy link
Contributor Author

altafan commented Sep 2, 2022

There is now a PR in ldk (#140) with ready to use support for psetv2.

@tiero shall we update the existing methods or do we want to be backward compatible and add new apis to make psetv2 swaps?

@tiero
Copy link
Contributor

tiero commented Sep 5, 2022

If possible, I think we should simply support both version of pset: when passed we try to serialize with moth Psbt and Pset classes under the hood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants