Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:when debug.breakpoints.onFailure is an empty string, redundant volumes appear #7788

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix:when debug.breakpoints.onFailure is an empty string, redundant volumes appear #7788

wants to merge 1 commit into from
+39 −1

Conversation

cugykw
Copy link
Contributor

@cugykw cugykw commented Mar 21, 2024 •
edited

Changes

Fixes: #7787

debug.breakpoints.onFailure is not allowed to be set to an empty string. Keep the conditions for judging the debug mode opening consistent and avoid adding redundant debug mode related volumes.

/kind bug

Submitter Checklist

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

debug.breakpoints.onFailure is not allowed to be set to an empty string.

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Mar 21, 2024
@tekton-robot
Copy link
Collaborator

Hi @cugykw. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Mar 21, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.0% 0.0

@cugykw
Copy link
Contributor Author

cugykw commented Mar 22, 2024

/test check-pr-has-kind-label

@cugykw
Copy link
Contributor Author

cugykw commented Mar 22, 2024

/assign @vdemeester

@tekton-robot
Copy link
Collaborator

@cugykw: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 10, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.0% 0.0

khrm
khrm reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are getting some lint error. Use precommit.
https://github.com/tektoncd/pipeline/blob/main/DEVELOPMENT.md#install-tools

@khrm
Copy link
Contributor

khrm commented Apr 10, 2024

/test pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator

@khrm: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.0% 0.0

@cugykw cugykw force-pushed the fix-debug-redundant-volumes branch from 3dea31e to b73c04c Compare April 11, 2024 00:57
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from vdemeester after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cugykw
Copy link
Contributor Author

cugykw commented Apr 11, 2024

You are getting some lint error. Use precommit. https://github.com/tektoncd/pipeline/blob/main/DEVELOPMENT.md#install-tools

@khrm Thanks for the help, I've fixed it.

@cugykw
Copy link
Contributor Author

cugykw commented Apr 11, 2024

/retest

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.0% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.0% 0.0

@cugykw
Copy link
Contributor Author

cugykw commented Apr 11, 2024

/test pull-tekton-pipeline-alpha-integration-tests

@cugykw
Copy link
Contributor Author

cugykw commented Apr 11, 2024

/test pull-tekton-pipeline-beta-integration-tests

@cugykw
Copy link
Contributor Author

cugykw commented Apr 11, 2024

/test pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator

@cugykw: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.0% 0.0

chitrangpatel
chitrangpatel reviewed May 14, 2024
View reviewed changes
pkg/apis/pipeline/v1beta1/taskrun_validation.go
if db.Breakpoints.OnFailure == "" {
errs = errs.Also(apis.ErrInvalidValue("onFailure breakpoint is empty, it is only allowed to be set as enabled", "breakpoints.onFailure"))
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a corresponding change not needed in apis/pipeline/v1/taskrun_validation.go?

@cugykw cugykw force-pushed the fix-debug-redundant-volumes branch from b73c04c to 610273b Compare May 16, 2024 12:59
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 16, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_validation.go 97.0% 97.0% 0.0
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 97.0% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_validation.go 97.0% 97.0% 0.0
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 97.0% 0.0

@cugykw
Copy link
Contributor Author

cugykw commented May 16, 2024

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khrm khrm khrm left review comments

@chitrangpatel chitrangpatel chitrangpatel left review comments

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vdemeester vdemeester

Labels
kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Pipeline v0.60
Development

Successfully merging this pull request may close these issues.

When debug is not turned on correctly, redundant volumes appear
6 participants
@cugykw @tekton-robot @afrittoli @khrm @chitrangpatel @vdemeester