Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add namespace label/tag to throttling metrics #7878

Closed
gabemontero opened this issue Apr 12, 2024 · 1 comment · Fixed by #7879
Closed

add namespace label/tag to throttling metrics #7878

gabemontero opened this issue Apr 12, 2024 · 1 comment · Fixed by #7879
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@gabemontero
Copy link
Contributor

Feature request

Back when implementing #6744 for #6631
we failed to realize that with k8s quota policies being namespace scoped, knowing which namespace the throttled items were
in could have some diagnostic value.

Now that we have been using the metric added for a bit, this realization is now very apparent.

Also, since last touching this space, the original metric was deprecated and
a new one with a shorter name was added. This change only updates the non-deprecated metric with the new label.

Also, I'm uncertain wrt the flexibility we have with adding labels/tags to existing metrics, as in a way it changes behavior. Does the fact that the metric is classified as experimental give us any flexibility? Do we have to go as far as creating a duplicate metric with the new label? I've asked in slack as well at https://tektoncd.slack.com/archives/CLCCEBUMU/p1712853469509439

I will be submitting an initial PR that adds the label to the existing metric that is not deprecated. I am leaving the deprecated metric alone.

Use case

As a tekton administrator, I need to be able to easily see, possibly alert on, whichever subsets of the namespaces in my cluster and experienced k8s throttling of taskruns or pipelineruns with taskruns or custom task runs, etc. etc.

@gabemontero gabemontero added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 12, 2024
@khrm
Copy link
Contributor

khrm commented Apr 16, 2024

/assign @gabemontero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants