Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass Content-Type Header to Interceptor #1615

Merged
merged 1 commit into from May 6, 2024
Merged

Pass Content-Type Header to Interceptor #1615

merged 1 commit into from May 6, 2024

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Jul 17, 2023 •
edited

Content-Type should be passed to the interceptor while making the POST Request. Some frameworks in different languages like Java require this. So interceptor request fails with 415 in those.

Fixes #1614

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Now `Content-Type: application/json` is passed to the interceptor while making the request.

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2023
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Jul 17, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/interceptors.go 89.1% 89.4% 0.2

@khrm
Copy link
Contributor Author

khrm commented Jul 17, 2023

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 17, 2023
@khrm
Copy link
Contributor Author

khrm commented Jul 17, 2023

/test pull-tekton-triggers-integration-tests

1 similar comment
@khrm
Copy link
Contributor Author

khrm commented Jul 21, 2023

/test pull-tekton-triggers-integration-tests

dibyom
dibyom reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khrm let's add some tests, otherwise LGTM!

@khrm khrm added this to the Triggers v0.25 milestone Aug 18, 2023
khrm
khrm commented Aug 25, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am removing this from the milestone. We need another fix along with this.

@khrm khrm modified the milestones: Triggers v0.25, Triggers v0.26 Aug 25, 2023
@bigkevmcd
Copy link
Member

@khrm Do you want me to take this on, I have some time just now.

Not quite sure what you mean by #1615 (review) ?

@khrm
Pass Content-Type Header to Interceptor
fb3320c 
`Content-Type` should be passed to interceptor while making POST Request. Some
framework in different languages like java require this. So interceptor request
fails with 415 in those.
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2024
@khrm
Copy link
Contributor Author

khrm commented Apr 4, 2024

Sorry, @bigkevmcd. I didn't see your message. I just saw it today.

khrm
khrm commented Apr 4, 2024
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dibyom @savitaashture
Let's get this merge.

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/interceptors.go 89.1% 89.4% 0.2

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
savitaashture
savitaashture reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@tekton-robot tekton-robot merged commit b5fc165 into tektoncd:main May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigkevmcd bigkevmcd bigkevmcd left review comments

@savitaashture savitaashture savitaashture left review comments

@dibyom dibyom dibyom approved these changes

@iancoffey iancoffey Awaiting requested review from iancoffey

@ncskier ncskier Awaiting requested review from ncskier

Assignees

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Triggers v0.27
Development

Successfully merging this pull request may close these issues.

Content-Type isn't send to Interceptor
5 participants
@khrm @tekton-robot @bigkevmcd @dibyom @savitaashture