Fix the baseURL for dev and prod use caes #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The baseURL is not set for dev and prod which causes the following issues: - for dev, the URL shown on the console is not the correct one - for prod, the generated sitemap.xml uses relative URLs, which makes it not parsable by the search engine This is already setup correctly for deploy-previews. Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
tekton-robot
added
the
size/S
|
The sitemap in the preview still looks good: https://5fbfb2ff0f90740008113a06--tekton.netlify.app/sitemap.xml |
vdemeester
approved these changes
Nov 26, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The baseURL is not set for dev and prod which causes the following
issues:
makes it not parsable by the search engine
This is already setup correctly for deploy-previews.
Partially fixes #191
Signed-off-by: Andrea Frittoli andrea.frittoli@gmail.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
/cc @vdemeester