Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brew support for all binaries #3282

Merged
merged 9 commits into from
Jun 20, 2024

Conversation

lhriley
Copy link
Contributor

@lhriley lhriley commented Jul 27, 2023

Description

Add support for all platforms in one brew formula. This resolves: datawire/homebrew-blackbird#19

Checklist

  • I made sure to update ./CHANGELOG.yml.
  • I made sure to add any docs changes required for my change (including release notes).
  • My change is adequately tested.
  • I updated DEVELOPING.md with any special dev tricks I had to use to work on this code efficiently.
  • I updated TELEMETRY.md if I added, changed, or removed a metric name.
  • Once my PR is ready to have integration tests ran, I posted the PR in #telepresence-dev in the datawire-oss slack so that the "ok to test" label can be applied.

Signed-off-by: l.h. riley <liam.h.riley@gmail.com>
Signed-off-by: l.h. riley <liam.h.riley@gmail.com>
Signed-off-by: l.h. riley <liam.h.riley@gmail.com>
@knlambert knlambert added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Oct 3, 2023
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Oct 3, 2023
Signed-off-by: l.h. riley <lhriley@users.noreply.github.com>
Signed-off-by: l.h. riley <lhriley@users.noreply.github.com>
@thallgren thallgren force-pushed the release/v2 branch 2 times, most recently from 0c10946 to cb1d0d6 Compare October 18, 2023 11:25
@knlambert knlambert requested review from a team and shepz and removed request for a team October 19, 2023 17:53
@shepz shepz removed their request for review October 24, 2023 14:33
@lhriley
Copy link
Contributor Author

lhriley commented Nov 22, 2023

@shepz @thallgren @knlambert

Anything that I can do to get this moving forward before the end of the year?

lhriley and others added 2 commits November 28, 2023 13:36
Signed-off-by: l.h. riley <liam.h.riley@gmail.com>
@thallgren thallgren merged commit 33c03b7 into telepresenceio:release/v2 Jun 20, 2024
6 of 7 checks passed
@thallgren
Copy link
Member

Thanks @lhriley for providing this, and our apologies for the long delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linux: telepresence formula quietly installs broken binary
3 participants