Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comand line Comparison not working if extension is not lowercase #63

Open
sebastianslutzky opened this issue Mar 11, 2020 · 0 comments · May be fixed by #65
Open

Comand line Comparison not working if extension is not lowercase #63

sebastianslutzky opened this issue Mar 11, 2020 · 0 comments · May be fixed by #65

Comments

@sebastianslutzky
Copy link

sebastianslutzky commented Mar 11, 2020

Steps to reproduce it

Run the following powershell command

&"C:\Program Files (x86)\Telerik\JustAssembly\Libraries\JustAssembly.CommandLineTool.exe" "E:\git\compare\current\content\lib\ikvm\JVM.DLL" "E:\git\compare\server\content\lib\ikvm\JVM.DLL" "JVM.DLLJVM.DLL.xml"

Expected Result

Assembly comparison should execute and succeed

Actual Result

Error with message
First assembly path is in incorrect format or file not found.
Exit code: 1

workaround:

lower casing the file extensions for both inputs worked well

&"C:\Program Files (x86)\Telerik\JustAssembly\Libraries\JustAssembly.CommandLineTool.exe" "E:\git\compare\current\content\lib\ikvm\JVM.dll" "E:\git\compare\server\content\lib\ikvm\JVM.dll" "JVM.DLLJVM.DLL.xml"

Possible cause:

This class:
https://github.com/telerik/JustAssembly/blob/master/UI/JustAssembly.CommandLineTool/FilePathValidater.cs#L30

should be validating the input file extensions regardless their casing. at the moment, only lowercase "dll" or "exe" are valid inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant