Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored to support paginated audit log api. #770 #772

Merged
merged 1 commit into from May 14, 2024
Merged

Refactored to support paginated audit log api. #770 #772

merged 1 commit into from May 14, 2024

Conversation

SteveMcGrath
Copy link
Contributor

Description

Adds pagination support and an iterable to handle the pagination needs for the updated audit log events API.

Fixes #770

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Tested against a live environment to ensure the new iterable worked as expected,.

Test Configuration:

  • Python Version(s) Tested: 3.10.3

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SteveMcGrath SteveMcGrath requested a review from a team as a code owner May 10, 2024 21:52
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
95.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SteveMcGrath SteveMcGrath merged commit 64f0f5a into master May 14, 2024
15 checks passed
@SteveMcGrath SteveMcGrath deleted the feature/770 branch May 14, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkeuning nkeuning nkeuning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TVM Activity Log Pagination
2 participants
@SteveMcGrath @nkeuning