Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: constructor param to trigger cleanup upon destruction #330

Open
troglodyne opened this issue Aug 7, 2017 · 3 comments
Open
Assignees

Comments

@troglodyne
Copy link

I've had to add reaper configuration/scripts to selenium heads due to dies in Selenium::Remote::Driver tests (or END blocks to tests themselves) that just call $obj->quit(); to cleanup any windows. I know that leaving windows up when something dies can be useful for diagnostic purposes, but when not "debugging" why a test would fail, you really don't need this.

As such, I would like to request that the new() constructor be given a named argument (acting as a flag) to enable automatic reaping of the window(s) we spawned during execution. Then I could just set that in my constructors instead and not have to worry about that as much.

@teodesian
Copy link
Owner

I assume we don't want it to clean up on SIGINT? Or should that be controllable too?

@troglodyne
Copy link
Author

Yes, I'd presume that if the user interrupted the script (SIGINT), they would want the window to stay there for examination.

@teodesian teodesian self-assigned this Sep 6, 2017
@teodesian
Copy link
Owner

Ok, will aim to make this next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants