Skip to content

Commit

Permalink
Reserve extra byte in LoadDataFromFile() in case caller wants to appe…
Browse files Browse the repository at this point in the history
…nd '\0'
  • Loading branch information
Paul Kitchen authored and Paul Kitchen committed Jun 5, 2018
1 parent 83ae900 commit 805fb76
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/ccutil/genericvector.h
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,8 @@ inline bool LoadDataFromFile(const char* filename, GenericVector<char>* data) {
fseek(fp, 0, SEEK_SET);
// Trying to open a directory on Linux sets size to LONG_MAX. Catch it here.
if (size > 0 && size < LONG_MAX) {
// reserve an extra byte in case caller wants to append a '\0' character
data->reserve(size + 1);
data->resize_no_init(size);
result = static_cast<long>(fread(&(*data)[0], 1, size, fp)) == size;
}
Expand Down

0 comments on commit 805fb76

Please sign in to comment.