Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landmines can be pressed by thin windows #83112

Closed
EEASAS opened this issue May 7, 2024 · 1 comment · Fixed by #83156
Closed

Landmines can be pressed by thin windows #83112

EEASAS opened this issue May 7, 2024 · 1 comment · Fixed by #83156
Assignees
@ShizCalev
Labels
Bug Correct Functionality Consistency Issue The dev team didn't think of everything

Comments

@EEASAS
Copy link
Contributor

EEASAS commented May 7, 2024 •
edited by github-actions bot

Reporting client version: 515.1636

Issue Summary

Mapped landmines can be pressed by a thin window, causing it to explode if you step on it, rather than stepping on it
and stepping off

Round ID:

228465

Testmerges:

Reproduction:

Examine a landmine that is behind a windoor or thindow
image
image
@ShizCalev ShizCalev self-assigned this May 7, 2024
@ShizCalev ShizCalev added Bug Correct Functionality Oversight We have no quality control Consistency Issue The dev team didn't think of everything and removed Oversight We have no quality control labels May 7, 2024
@ShizCalev
Copy link
Member

ShizCalev commented May 8, 2024 •
edited

Got it fixed, just tweaking some visual timings. Will pr tonight

@ShizCalev ShizCalev mentioned this issue May 9, 2024
Merged
Ghommie pushed a commit that referenced this issue May 16, 2024
@ShizCalev
Atoms that are on the border of a tile will now only trigger landmine…
959477c 
…s if they actually pass over said landmine (#83156)

Fixes #83112



https://github.com/tgstation/tgstation/assets/6209658/13531391-6233-471a-8653-a68fc6ea7543



Muh immersion.


:cl: ShizCalev
fix: Atoms on the border of a tile will now only trigger landmines if
they ACTUALLY pass over said mine.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShizCalev ShizCalev

Labels
Bug Correct Functionality Consistency Issue The dev team didn't think of everything
Projects
None yet
Milestone
No milestone
2 participants
@ShizCalev @EEASAS