Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

human bitrunning glitches get gibbed when attempting to escape the domain through an emagged server #83181

Closed
Y0SH1M4S73R opened this issue May 11, 2024 · 3 comments · Fixed by #83184
Closed

human bitrunning glitches get gibbed when attempting to escape the domain through an emagged server #83181

Y0SH1M4S73R opened this issue May 11, 2024 · 3 comments · Fixed by #83184
Assignees
@jlsnow301

Comments

@Y0SH1M4S73R
Copy link
Contributor

Y0SH1M4S73R commented May 11, 2024 •
edited by github-actions bot

Issue Summary

reset_equipment qdels all datums in get_contents before re-equipping the outfit. For humans, get_contents includes bodyparts. When the chest gets deleted, the mob gets gibbed.

Round ID: 228672

Testmerges:

#82298

Reproduction:

  1. Emag bitrunning server
  2. Spawn cyberpolice or cybertac
  3. Try to escape
  4. Get gibbed
@Y0SH1M4S73R
Copy link
Contributor Author

This bug fucked me out of being able to assault the station as a cybertac
And the admins had the gall to just let a random applying ghost get the amelioration

@SyncIt21
Copy link
Contributor

Duplicate #82973

@Y0SH1M4S73R
Copy link
Contributor Author

well this issue explains the code responsible for the bug

@jlsnow301 jlsnow301 self-assigned this May 11, 2024
This was referenced May 11, 2024
Closed
Merged
Ghommie pushed a commit that referenced this issue May 15, 2024
@jlsnow301 @Time-Green
Fixes some bitrunning related issues [no gbp] (#83184)
fce5209 
## About The Pull Request
Properly allows bitrunning antagonists to come station side

A few issues were resolved:
- Event title was too lengthy, it's been renamed
- IDs were not being named properly for cyber police. Cybertac would
appear as "unknown"
- Runtime at examining cyber police ID because it had an erroneous
account
- Teleporting station side would delete your organs and leave you a
broken husk of a mob
## Why It's Good For The Game
Fixes #83181
## Changelog
:cl:
fix: Bitrunning antagonists no longer gib on teleport
fix: Cyber tac now have a visible name / ID
fix: Renamed the bitrunning malfunction event to just "Malfunction: x"
/:cl:

---------

Co-authored-by: Time-Green <7501474+Time-Green@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlsnow301 jlsnow301

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes some bitrunning related issues [no gbp] jlsnow301/tgstation
3 participants
@Y0SH1M4S73R @jlsnow301 @SyncIt21