Solve updating mail notification values on sqlite, too much users fro…

…m Project#notified_users. #6541 Contributed by Felix Schäfer
thegcat · Sep 30, 2010 · ea2642f · ea2642f
1 parent d06a1a7
commit ea2642f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app/models/project.rb b/app/models/project.rb
@@ -382,12 +382,12 @@ def assignable_users
 
   # Returns the mail adresses of users that should be always notified on project events
   def recipients
-    members.select {|m| m.mail_notification? || m.user.mail_notification == 'all'}.collect {|m| m.user.mail}
+    notified_users.collect {|u| u.mail}
   end
 
   # Returns the users that should be notified on project events
   def notified_users
-    members.select {|m| m.mail_notification? || m.user.mail_notification?}.collect {|m| m.user}
+    members.select {|m| m.mail_notification? || m.user.mail_notification == 'all'}.collect {|m| m.user}
   end
 
   # Returns an array of all custom fields enabled for project issues

diff --git a/db/migrate/20100129193813_update_mail_notification_values.rb b/db/migrate/20100129193813_update_mail_notification_values.rb
@@ -1,8 +1,8 @@
 # Patch the data from a boolean change.
 class UpdateMailNotificationValues < ActiveRecord::Migration
   def self.up
-    User.update_all("mail_notification = 'all'", "mail_notification = '1'")
-    User.update_all("mail_notification = 'only_my_events'", "mail_notification = '0'")
+    User.update_all("mail_notification = 'all'", "mail_notification IN ('1', 't')")
+    User.update_all("mail_notification = 'only_my_events'", "mail_notification IN ('0', 'f')")
   end
 
   def self.down