Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $Config{siteprefix} as default directory for etc. #265

Merged
merged 1 commit into from Oct 13, 2015
Merged

Use $Config{siteprefix} as default directory for etc. #265

merged 1 commit into from Oct 13, 2015

Conversation

carragom
Copy link
Contributor

Fixes #264. This will use $Config{siteprefix} instead of $Config{prefix} to place the etc directory on a default install, to be consistent with the rest of the files. Also it will give priority to the value of install_base over prefix since it seem to be the recommended way in Module::Build's docs.

@theory
Copy link
Collaborator

theory commented Oct 12, 2015

I think it might make sense to check the Module::Build installdirsattribute and select the Config key appropriately. Something like:

my $which = $self->installdirs;
$which = '' if $which eq 'core';
my $prefix = $self->installdirs eq 'core'   ? $Config{prefix}
           : $self->installdirs eq 'site'   ? $Config{siteprefix}   || $Config{prefix}
           : $self->installdirs eq 'vendor' ? $Config{vendorprefix} || $Config{siteprefix} || $Config{prefix};

@carragom
Copy link
Contributor Author

Makes sense. Here is another stab at it. Code is a little different but should achieve the same. Let me know what you think. By the way, thanks for the great piece of software.

@theory theory merged commit 9c52c58 into sqitchers:master Oct 13, 2015
@theory theory added this to the v1.0.0 milestone Oct 13, 2015
@carragom carragom deleted the master branch October 2, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants