Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Command Ignores Dependencies #36

Closed
theory opened this issue Aug 16, 2012 · 2 comments
Closed

Revert Command Ignores Dependencies #36

theory opened this issue Aug 16, 2012 · 2 comments
Labels

Comments

@theory
Copy link
Collaborator

theory commented Aug 16, 2012

The revert command does not validate dependencies. It should be updated to check that a change to be reverted is not required by some other change.

@theory
Copy link
Collaborator Author

theory commented Aug 17, 2012

I think this is going to be a fairly significant change. Currently, dependencies are just stored as strings from the as_string method from App::Sqitch::Plan::Depend -- more or less the dependency just as it was passed to Sqitch by the user. However, it will need to resolve those to IDs in order to validate them. I think the way to do that is going to be to store them. So on deploy, rather than store dependencies in arrays, I think we need to store them in another table, where a FK constraint has the ID that the dependency resolved to, and other columns have the as_string representation of the dependency and a boolean to indicate whether it is required or conflicting.

So that will have to be for the next release, I think. Need to get cross-project dependencies out now.

@theory
Copy link
Collaborator Author

theory commented Aug 23, 2012

Fixed and merged as of 1258b94.

@theory theory closed this as completed Aug 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant