Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Angular 13 #76

Open
elvirusDE opened this issue Jun 14, 2022 · 4 comments · May be fixed by #85
Open

Compatibility with Angular 13 #76

elvirusDE opened this issue Jun 14, 2022 · 4 comments · May be fixed by #85

Comments

@elvirusDE
Copy link

elvirusDE commented Jun 14, 2022

Does anyone have this problem? My prod build does not build because of dependency conflicts. It seems to me that the package is not ready for Angular 13.

Log output:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @thisissoon/angular-inviewport@4.2.2
npm ERR! Found: @angular/core@13.3.6
npm ERR! node_modules/@angular/core
npm ERR!   @angular/core@"~13.3.6" from the root project
npm ERR!   peer @angular/core@"13.3.6" from @angular/animations@13.3.6
npm ERR!   node_modules/@angular/animations
npm ERR!     @angular/animations@"~13.3.6" from the root project
npm ERR!     peer @angular/animations@"^13.0.0 || ^14.0.0-0" from @angular/material@13.3.6
npm ERR!     node_modules/@angular/material
npm ERR!       @angular/material@"^13.3.6" from the root project
npm ERR!     1 more (@angular/platform-browser)
npm ERR!   10 more (@angular/cdk, @angular/common, @angular/flex-layout, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/core@">=5.0.0 <9.0.0" from @thisissoon/angular-inviewport@4.2.2
npm ERR! node_modules/@thisissoon/angular-inviewport
npm ERR!   @thisissoon/angular-inviewport@"^4.2.2" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @angular/core@8.2.14
npm ERR! node_modules/@angular/core
npm ERR!   peer @angular/core@">=5.0.0 <9.0.0" from @thisissoon/angular-inviewport@4.2.2
npm ERR!   node_modules/@thisissoon/angular-inviewport
npm ERR!     @thisissoon/angular-inviewport@"^4.2.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /tmp/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/.npm/_logs/2022-06-14T08_02_56_177Z-debug-0.log

What can I do to get my project build again? Any ideas?

@andypwarren
Copy link

Your assumption is correct, this package hasn't been tested with Angular 13 as we aren't actively developing it anymore. Happy to accept PR's if you find a fix.

@elvirusDE
Copy link
Author

Ok, thank you for your reply.

  1. Is there any replacement available because unfortunately I am dependent on this package...
  2. There are a lot of open PRs in the project. If I update the dependencies, would you incorporate my PR or am I supposed to fork the project in order to continue?

@andypwarren
Copy link

  1. I'm not sure I haven't looked into this for a while.
  2. I'd suggest forking it, making the changes and then submitting an MR

@elvirusDE
Copy link
Author

I made a pull request for the update. It is compatible with Angular 14.
I also have published my fork as @elvirus/angular-inviewport and tested it with my application and it is working as expected.

@localpcguy localpcguy linked a pull request Jul 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants