Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seqno request forwarding only considers the same path #169

Closed
LeeSmet opened this issue Mar 20, 2024 · 0 comments
Closed

Seqno request forwarding only considers the same path #169

LeeSmet opened this issue Mar 20, 2024 · 0 comments
Assignees
Labels
type_bug Something isn't working

Comments

@LeeSmet
Copy link
Contributor

LeeSmet commented Mar 20, 2024

Currently seqno requests are forwarded naively to "the best route" according to the router. However, in case the request is repeated within some time, it needs to be forwarded to a different route. Currently seqno's aren't used as much, but as the network grows and more unstable links appear, this will be needed to more efficiently resolve connection stalls (compared to just waiting for an expiration on the source entry).

@LeeSmet LeeSmet added the type_bug Something isn't working label Mar 20, 2024
@LeeSmet LeeSmet self-assigned this May 24, 2024
LeeSmet added a commit that referenced this issue May 27, 2024
Previously we just tried to find the same route when forwarding a seqno
request. Now we record the forward info in the cache, while also
improving the search. That is, we try to forward to a peer we haven't
used yet (but we don't do a fanout/broadcast search), and also actually
do our very best to forward the request. If we know that didn't work,
use a different peer.

Fixes #169

Signed-off-by: Lee Smet <lee.smet@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant