Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: quic crashes on start-stop-start cycle #251

Open
iwanbk opened this issue May 15, 2024 · 5 comments
Open

mobile: quic crashes on start-stop-start cycle #251

iwanbk opened this issue May 15, 2024 · 5 comments
Assignees
Labels
type_bug Something isn't working

Comments

@iwanbk
Copy link
Member

iwanbk commented May 15, 2024

On Android (and probably on iOS as well), latest mycelium crashed on start-stop-start cycle.

steps to reproduce:

  • start android mycelium
  • stop
  • start again

image

Crash message doesn't really point out to quic.
But it is fixed when we force is_private_net var to true

let is_private_net = private_network_config.is_some();

Do we need QUIC on mobile device?
If no, maybe we can disable it as well.

In case we disable it, i think we still need to fix it because this crashes mean there is some process that is not gfacefully shut down

@iwanbk iwanbk added the type_bug Something isn't working label May 15, 2024
@iwanbk
Copy link
Member Author

iwanbk commented May 15, 2024

On Android (and probably on iOS as well)

i found that it doesn't crash on iOS

@LeeSmet
Copy link
Contributor

LeeSmet commented May 15, 2024

This is rather strange that it only crashes on quic sockets on android. Regardless given that it happens on a second start, I feel that it's caused by not properly cleaning up when the process is done. Mycelium basically spawns a bunch of background tasks which run forever. Up until now, this was fine, since on desktop, if the node exits, we just exit the whole process.

@iwanbk
Copy link
Member Author

iwanbk commented May 15, 2024

Up until now, this was fine, since on desktop, if the node exits, we just exit the whole process.

FYI, it was fine when i'm working on this PR.
#239

So, it broke after/around that time

@LeeSmet LeeSmet self-assigned this May 15, 2024
@LeeSmet LeeSmet reopened this May 15, 2024
@LeeSmet
Copy link
Contributor

LeeSmet commented May 22, 2024

@iwanbk I assume this is working properly now?

@iwanbk
Copy link
Member Author

iwanbk commented May 24, 2024

@iwanbk I assume this is working properly now?

i haven't tested it yet because i disable QUIC now.
will test it next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
Status: In Verification
Development

No branches or pull requests

2 participants