-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidy implementation for tseries::garch #323
Conversation
4a085c2
to
09dab09
Compare
The implementation of the tidy methods, tidy, glance and augment, for the garch class of tseries package.
It looks like an example that loads the entire tidyverse (which isn't listed in Suggested) is causing the build error. I would try to use just the packages you need in the example, and then make sure that R CMD check passes locally. Let me know if you need any help! |
I am trying to run check but it is returning the following error
while evaluates the code below in ggplot(boot_coefs, aes(estimate)) +
geom_histogram(binwidth = 2) +
facet_wrap(facets = vars(term), scales = "free") I guess it is being caused by |
It's building for me locally, and your AppVeyor build passed, which is promising. Maybe try updating your packages? I just added a commit to use tidyverse style and return tibbles. If that passes the AppVeyor I'll merge. I also added you as a contributor. |
Thank you so much! |
Great @alexpghayes! This is awesome. |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
The implementation of the tidy methods, tidy, glance and augment, for the garch class of tseries package.