lfe-tidier: add argument quick to tidy

[MatthieuStigler]

Hi

tidy.felm did not have the quick option, which was very useful in my case. I made an implementation of it, trying to keep code as in other functions. I did local test, but no global ones (difficult to run R CMD check as so many packages required)... I hope it's fine!?

Thanks!

[alexpghayes]

This looks great! Can you add some tests for tibble output when quick = TRUE? Or just construct a tibble instead of a data.frame?

[MatthieuStigler]

ok, I did following changes:

• use directly data_frame
• added tests with quick=TRUE in test-lfe.R

I also corrected my own change, where now quick takes precedence over conf.int=TRUE (i.e. if (conf.int) becomes if (!quick & conf.int)). This seemed to be the policy in broom, am I correct?

Thanks

[alexpghayes]

Looks good, thanks! Will you update NEWS and add yourself as a contributor in DESCRIPTION?

[MatthieuStigler]

ok, I did! It seems now it is not passing the test, but seems for a totally different reason?

[github-actions]

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.