Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: export 'takeUntil' (imported as 'takeUntil') was not found in 'rxjs' in latest version 8.0.0 #388

Closed
Mehadmushtaq opened this issue May 10, 2024 · 2 comments
Labels

Comments

@Mehadmushtaq
Copy link

i installed the latest available version of @tinymce/tinymce-angular which is 8.0.0, after successful installation when i try to build my project it throws an unexpected error as you can see below:

image

when i just navigate to tinymce-tinymce-angular.mjs i found that takeUntil is imported directly from rxjs which was changed after rxjs v5 and now we have to import it from "rxjs/operators" instead of "rxjs" that i throwing error.

here is the image showing tinymce-tinymce-angular.mjs file:
image

@danoaky-tiny
Copy link
Contributor

danoaky-tiny commented May 12, 2024

RxJS has deprecated the 'rxjs/operators' import since v7.2.0 (3 years ago).
Although I understand that Angular 17 still supports using RxJS ^6.5.3. So at the very least I think we should add RxJS v7.4.0 as a peer dependency to this package.
Internal ref: INT-3306

Personally I'm much less inclined to put back support for deprecated RxJS imports, but if more people have this problem we'll consider a patch for it.

@danoaky-tiny
Copy link
Contributor

Closing, as #389 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants