Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port additional extensions #22

Open
tmcgilchrist opened this issue Sep 15, 2018 · 3 comments
Open

Port additional extensions #22

tmcgilchrist opened this issue Sep 15, 2018 · 3 comments

Comments

@tmcgilchrist
Copy link
Owner

@erikd
Copy link
Collaborator

erikd commented Sep 15, 2018

Some of those we already have, some under then same name (firstEitherT) and others under a different name (tryEitherT in X is basically handleEitherT).

I've been using transformers-either quite a bit and have not missed any of these. My advice would be if you think you need them, cargo-cult them into the projects where you need them and only when you have used them for a while (in a couple of different projects) add them to transformers-either.

@tmcgilchrist
Copy link
Owner Author

Good to know you haven't really needed any of the extra pieces, I've been in other languages more recently. I pulled joinErrors :: (Functor m, Monad m) => (x -> z) -> (y -> z) -> EitherT x (EitherT y m) a -> EitherT z m a into mismi which was using it. Happy to leave it there and see if I do find another use for it.

@erikd
Copy link
Collaborator

erikd commented Sep 15, 2018

I don't have any particularly string feelings, but I do thing its a good idea make sure anything we add is genuinely useful across more than one project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants