New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category names contain spaces for images #32
Comments
Quickly thinking, it'd make sense to replace spaces with an underscore for the term & location values. For other values (title) the space can remain. Certainly needs a change as it is. Other thoughts/opinions? |
Seems like the fix should go here: https://github.com/tmetsch/occi-os/blob/stable/folsom/occi_os_api/wsgi.py#L175 |
Shouldn't the Category be the uuid of the image? One can have several images with the very same name (i.e. "OpenSuSE 12.1 Minimal"), but with different ids. |
No - the mixin only points to a image that can be instantiated. An image should be a unique template (collection of software). The UUID would be better associated with the VM as it is in the OCCI-OS implementation, where there are multiple VM instances of the same image. |
Hi, from my point of view, images as well as VMs can have UUIDs. And like Cheers, On 04.03.2013 14:36, Andy Edmonds wrote :
Dipl.-Inform. Björn Hagemeier Phone: +49 2461 61 1584 JSC is the coordinator of the Forschungszentrum Juelich GmbH Prof. Dr. Sebastian M. Schmidt |
Images do have UUIDs (the glance's id column). Consider the following real example from our glance installation:
These are two different images with the same name. Even though I think that it is not correct to have different images with the same global name, this could happen (as in the example) when users upload their own images, that's why the |
Fair point. I guess my initial reaction was one based on the fear of people confabulating occi.core.id and Category's term value. So long as they're not seen as the same then it's all gravy! :-) |
I'm not familiar with OS, please excuse any misconceptions, I will call a physical file containing filesystem(s) an image and a collection of resources (this collection can be instantiated) a VM template. Does I think that removing spaces from Category terms is a good place to start. |
|
Ok, I thought as much, I just needed to be sure. As the discussion goes on we are starting to mix "Category names contain spaces for images" should really be "Category terms contain spaces for os_tpl(s)" and it is about invalid terms in HTTP rendering breaking OCCI-OS' compatibility with rOCCI client. GFD.185 – OCCI HTTP Rendering (v1.1) says the following: |
Ok a 2 min fix. I've it now in the right place (wsgi.py).
|
Thank you very much 👍 |
I'm always happy to take payment in beer :-D |
If we get a chance to meet in person at some event in the near future, I will be happy to settle this debt :-) |
Your on! :-) |
Hi there,
when querying resources on a system, the image categories can contain spaces in them. For example:
Category: OpenSuSE 12.1 Minimal; scheme="http://schemas.openstack.org/template/os#"; class="mixin"; title="This is an OS OpenSuSE 12.1 Minimal VM image"; rel="http://schemas.ogf.org/occi/infrastructure#os_tpl"; location="https://myhost.mydomain:1234/OpenSuSE 12.1 Minimal/"
Should encoding be used to avoid these spaces? They don't seem to comply with the specification.
Best regards,
Björn
The text was updated successfully, but these errors were encountered: