Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForkingServer issue #7

Closed
tomerfiliba opened this issue Mar 2, 2011 · 1 comment
Closed

ForkingServer issue #7

tomerfiliba opened this issue Mar 2, 2011 · 1 comment
Labels
Bug Confirmed bug

Comments

@tomerfiliba
Copy link
Collaborator

a better solution would be to remove change @staticmethod to @classmethod and rename "self" as "cls",
but any working resolution is fine for now :)
i will release 3.0.8 in the summer, after my exams, to resolve all these little issues.

btw, if someone would volunteer to fix these quirks, i'll be glad to add him as a committer to github and sourceforge.

-tomer

An NCO and a Gentleman

  • hide quoted text -

On Fri, May 7, 2010 at 17:30, Tim Arnold a_j...@bellsouth.net wrote:
I guess you don't want a patch since it's already fixed in
development. I'm not sure your fix is the same as mine since I don't
have a deep understanding of the code. But just in case someone wants
it, this worked for me and my server no longer dies.

I changed the _handle_sigchld method in utils/server.py to no longer
be a static method. It now looks like this:


#    @staticmethod
   def _handle_sigchld(self,signum, unused):
       try:
           while True:
               os.waitpid(-1, os.WNOHANG)
       except OSError:
           pass
       # re-register signal handler (see man signal(2), under
Portability)
       signal.signal(signal.SIGCHLD, self._handle_sigchld)

Commenting out the @static_method decorator and adding self to the
signature.
As I said, everything seems to be working fine now.

any comments, suggestions are very welcome.
--Tim

On May 5, 3:53 pm, Tim Arnold a_j...@bellsouth.net wrote:

On May 5, 3:39 pm, Alex Grönholm alex.g...@nextday.fi wrote:

5.5.2010 21:30, Tim Arnold kirjoitti:> Hi,

I see in a few past posts that this error has been fixed in
development, but there has not yet been released. The traceback is
below. Is there a patch available, or could one be made available to
get this fixed? Or maybe a new release is coming soon?

I asked Tomer to release an updated version, but he hasn't acted on it.
The 3.5.x series isn't going to come out yet either due to me being busy
finishing my thesis.

Thanks for letting me know, I'll see if I can debug it myself.
thanks,
--Tim

many thanks,
--Tim Arnold

File "services.py", line 41, in
s.start()
File "/usr/local/lib/python2.7/site-packages/rpyc/utils/server.py",
line 167, in start
self.accept()
File "/usr/local/lib/python2.7/site-packages/rpyc/utils/server.py",
line 74, in accept
sock, (h, p) = self.listener.accept()
File "/usr/local/lib/python2.7/site-packages/rpyc/utils/server.py",
line 209, in _handle_sigchld
signal.signal(signal.SIGCHLD, self._handle_sigchld)
NameError: global name 'self' is not defined

@tomerfiliba
Copy link
Collaborator Author

fixes a28b882; closed by 7eb48a4; closed by 7eb48a4; closed by 7eb48a4; closed by 7eb48a4; closed by 7eb48a4; closed by 7eb48a4;

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

1 participant