Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License problem: please remove doc/image/lena.jpg #854

Closed
cdluminate opened this issue Jun 18, 2016 · 18 comments
Closed

License problem: please remove doc/image/lena.jpg #854

cdluminate opened this issue Jun 18, 2016 · 18 comments

Comments

@cdluminate
Copy link
Contributor

NN is distributed under BSD license however lena.jpg is not free.

According to Debian's policy checker:

lua-torch-nn source: license-problem-non-free-img-lenna doc/image/lena.jpg

The given source file is cropped from playboy centerfold.

This image is a picture of Lena S�derberg, shot by photographer Dwight
Hooker, cropped from the centerfold of the November 1972 issue of
Playboy magazine.

According to Hutchison, Jamie (May-June 2001). "Culture, Communication,
and an Information Age Madonna" (PDF). IEEE Professional Communication
Society Newsletter 45 (3). (page 5 second column second paragraph), this
image is distributable but not free.

Moreover, Lenna photo has been pointed to as an example of sexism in the
sciences, reinforcing gender stereotypes.

Please use well known and free test images.
@soumith
Copy link
Member

soumith commented Jun 18, 2016

while i would like to, there are likely downstream unit tests based on this image that would break. I dont want to break userland.

@cdluminate
Copy link
Contributor Author

Understand. I searched the code and find this:

$ ack lena
doc/convolution.md
775:lena = image.rgb2y(image.lena())
778:processed = m:forward(lena)
779:w1=image.display(lena)
782:![](image/lena.jpg)![](image/lenap.jpg)

I think only the doc needs lena.jpg, and unit test test.lua involves no lena.jpg test.

lena is a good example for CV people but in order to meet the legal requirement, I have to deal with this image downstream, deleting it and breaking the document integrity. Could you please consider an alternative free test image?

@nicholas-leonard
Copy link
Member

We could just replace lena.jpg with a creative commons image of the same
size (and still call it lena.jpg). I don't think any unit tests rely on the
exactness of the image being lenna.

Nicholas Léonard
917-741-7570

On Sat, Jun 18, 2016 at 10:13 PM, Lumin Zhou notifications@github.com
wrote:

Understand. I searched the code and find this:

$ ack lena
doc/convolution.md
775:lena = image.rgb2y(image.lena())
778:processed = m:forward(lena)
779:w1=image.display(lena)
782:

I think only the doc needs lena.jpg, and unit test test.lua involves no
lena.jpg test.

lena is a good example for CV people but in order to meet the legal
requirement, I have to deal with this image downstream, deleting it and
breaking the document integrity. Could you please consider an alternative
free test image?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#854 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ADW4ZbD2P3vEuoqCJUr3vEqbBLqhvX-Uks5qNKXPgaJpZM4I46gU
.

@cdluminate
Copy link
Contributor Author

@nicholas-leonard @soumith

I thinks there are only two points related to lena:

  1. the document uses lena.jpg as original example image
  2. the document uses lenap.jpg, as convolution output example image.

So expected changes are 2. I can do them if you dicide which picture to use.

@fmassa
Copy link
Contributor

fmassa commented Jun 21, 2016

We will then face the same problem with image, right? There are several images there, including lena https://github.com/torch/image/tree/master/assets

@cdluminate
Copy link
Contributor Author

@fmassa I'm afraid yes. lena is a high-frequency trouble maker in Debian community: we reported similar lena-removal requests to e.g. python-skimage to avoid their debian packages being removed from official release.

scikit-image/scikit-image#1855
scikit-image/scikit-image#2091 (comment)

@cdluminate
Copy link
Contributor Author

cdluminate commented Jun 21, 2016

How about using an alternative image and temporarily create a symbol link lena.jpg -> free_test_image.jpg

@cdluminate
Copy link
Contributor Author

I had a quick look at image, and I think I may simply remove lena.jpg and lena.png, and patch the image.lena() function to make it return a randn(lena_image_size) Tensor and explain the reason of removing it, because in this package lena picture is used in unit test.

@andreaskoepf
Copy link
Contributor

So I will have to go to wikipedia's lena image, or www.lenna.org and download that to do some standard testing? To replace lena with a different natural image (as suggested by @nicholas-leonard ) would be ok IMO but please not by random values.

@cdluminate
Copy link
Contributor Author

cdluminate commented Jun 23, 2016

@andreaskoepf I think I should print the true lena image link in the modified image.lena() function. Random noise is the simplest solution but I know its meaningless for image processing or anything else, however I don't know what image is both well-known test image and free image.

https://en.wikipedia.org/wiki/Standard_test_image

Debian logo is CC/LGPL licensed but maybe it's a bad option here.
https://www.debian.org/logos/

@nicholas-leonard
Copy link
Member

That standard image should do the trick.

Nicholas Léonard
917-741-7570

On Wed, Jun 22, 2016 at 10:02 PM, Lumin Zhou notifications@github.com
wrote:

@andreaskoepf https://github.com/andreaskoepf I think I should print
the true lena image link in the modified image.lena() function. Random
noise is the simplest solution but I know its meaningless for image
processing or anything else, however I don't know what image is both well-known
test image and free image.

https://en.wikipedia.org/wiki/Standard_test_image

Debian logo is CC/LGPL licensed but I think it's a bad option here.
https://www.debian.org/logos/


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#854 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ADW4ZbmQLAA_6jcLKL2B-zKMB4ITnij1ks5qOekugaJpZM4I46gU
.

@soumith
Copy link
Member

soumith commented Jun 23, 2016

I'll change it tomorrow

@cdluminate
Copy link
Contributor Author

@nicholas-leonard did you mean the image in this page:
https://en.wikipedia.org/wiki/Standard_test_image
which is a sample from USC-SIPI dataset?

Well with a closer look I found that this image is indeed available for this purpose:
the picture jelly beans https://en.wikipedia.org/wiki/File:SIPI_Jelly_Beans_4.1.07.tiff
lies in section 4.1.07, 4.1.08 of that dataset and is free to use.
http://sipi.usc.edu/database/copyright.php

How do you like this solution?
replace lena image with jelly bean, keeping the filename lena.jpg, and update corresponding convolution output lenap.jpg.

@nicholas-leonard
Copy link
Member

Yeah I mean the Standard_test_image.

@soumith
Copy link
Member

soumith commented Jul 31, 2016

fixed via torch/image@797fcb1

following Matplotlib and Pillow to add grace hopper instead
matplotlib/matplotlib#1581

@soumith soumith closed this as completed Jul 31, 2016
@cdluminate
Copy link
Contributor Author

Thanks for fixing it!

@chrisranderson
Copy link

I think it would be best if any references to Lena in this repo were removed because of its pornographic (and thus objectification of women, all-other-bad-things-about-pornography-here) origins. Is this possible?

@soumith
Copy link
Member

soumith commented Aug 29, 2016

we've removed lena. we cant change the name because of breaking API. See: torch/image@797fcb1

Hopefully we consider the topic closed here.

@torch torch locked and limited conversation to collaborators Aug 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants