Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on how to convert Signal to torch.Tensor (or smarter solution?) #436

Open
turian opened this issue Dec 15, 2023 · 0 comments

Comments

@turian
Copy link
Collaborator

turian commented Dec 15, 2023

One gotcha is when we have a Signal but we want is just as a torch.Tensor, otherwise logging and pickling and lightning stuff fails. But I forget how to do that and it's undocumented.

Simplest fix is to document it.

Removing Signal might be a bad idea? Not sure. Possibly we convert it to namedtuple so I can be type-checked.

(p.s. should we start using typeguard? We can just drop it in and say every class should be typechecked at runtime)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant