New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synth.set_parameters, should this be [0,1] or full range? #439

Open

turian opened this issue Dec 20, 2023 · 1 comment

Collaborator

turian commented Dec 20, 2023

I'm trying to pass 0,1 but it's breaking. The documentation doesn't help. And it's not clear how to set 0,1 parameters from synth if I want to.

(Perhaps we should also consider typing parameters something, as either 0,1 or original range?)

Collaborator Author

turian commented Dec 20, 2023

At the very least, I think we should be explicit in our method names, like

set_parameters_01range
set_parameters_origrange

so it's easier not to footgun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment